Missing NULL-check in XI2's implementation for get_window()
authorMario Sanchez Prada <mario.prada@samsung.com>
Thu, 16 May 2013 14:34:05 +0000 (15:34 +0100)
committerMatthias Clasen <mclasen@redhat.com>
Mon, 20 May 2013 01:21:41 +0000 (21:21 -0400)
Add missing check in gdk_x11_device_manager_xi2_get_window(), returning
NULL if no valid XI2Event* has been found. Calling code seems to be
prepared to handle NULLs coming from this function, so it should be
safe enough (e.g. check gdk_event_source_get_filter_window()).

https://bugzilla.gnome.org/show_bug.cgi?id=700465

gdk/x11/gdkdevicemanager-xi2.c

index 751343a122a35465928ce09abf8333c3c523e3f6..b9093b90899112ca5d82615c82ad7782d8dd9828 100644 (file)
@@ -1682,6 +1682,8 @@ gdk_x11_device_manager_xi2_get_window (GdkEventTranslator *translator,
     return NULL;
 
   ev = (XIEvent *) xevent->xcookie.data;
+  if (!ev)
+    return NULL;
 
   get_event_window (translator, ev, &window);
   return window;